✨ import enhancements done in trutificationdemo#29
Merged
carlosthe19916 merged 4 commits intoguacsec:mainfrom Mar 25, 2025
Merged
✨ import enhancements done in trutificationdemo#29carlosthe19916 merged 4 commits intoguacsec:mainfrom
carlosthe19916 merged 4 commits intoguacsec:mainfrom
Conversation
Contributor
carlosthe19916
commented
Mar 25, 2025
carlosthe19916
commented
- setting back the "cherry-pick" label for selecting backports. The reason is that there are other parts in the repository that rely on a pre-stablished "cherry-pick" label like for instance https://github.com/trustification/release-tools/blob/main/pkg/config/config.yaml#L96-L99
- The problem in the past seems to be that we could not find a regex that math the cherry-pick labels but while enhancing the trustificationdemo org I fixed it using
- Enhancing the Title verification error, now the GH log will contain which are the valid title prefixes.
- Introduce the create-release reusable action for generating releases and changelogs
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
# Conflicts: # .github/workflows/cherry-pick.yaml
|
Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits. |
ctron
reviewed
Mar 25, 2025
|
|
||
| const branches = labels.filter(label => label.startsWith('backport ')) | ||
| .map(label => label.substr(9)); | ||
| const branches = labels.filter(label => label.startsWith('cherry-pick/')) |
There was a problem hiding this comment.
I'd prefer backport over cherry-pick, as it's clearer what's supposed to happen.
Contributor
Author
There was a problem hiding this comment.
I'm collecting the current status of things, and I will explain it at guacsec/trustify#1472 what we have now. And we can certainly customize things like "cherry-pick" vs "backport".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.